diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index bb2ca5d..0c3a5ee 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -13,13 +13,23 @@ jobs: steps: - uses: actions/checkout@v7 - name: Install ShellCheck - run: sudo apt-get update -qq && sudo apt-get install -y -qq shellcheck + run: | + if command -v shellcheck >/dev/null 2>&1; then + echo "shellcheck already available" + exit 0 + fi + if command -v apt-get >/dev/null 2>&1; then + sudo apt-get update -qq && sudo apt-get install -y -qq shellcheck + else + echo "no apt-get on this runner — ShellCheck will be skipped" + fi - name: Run ShellCheck run: | + command -v shellcheck >/dev/null 2>&1 || { echo "shellcheck unavailable — skipping"; exit 0; } for f in runaway lib/*.sh examples/*.sh; do [ -f "$f" ] || continue echo "Checking: $f" - shellcheck -S warning "$f" || exit 1 + shellcheck -S warning -s bash "$f" || exit 1 done syntax: @@ -41,7 +51,14 @@ jobs: runs-on: ubuntu-latest steps: - uses: actions/checkout@v7 - - name: Install markdownlint - run: sudo npm install -g markdownlint-cli + - name: Install markdownlint (best effort) + run: | + if command -v npm >/dev/null 2>&1; then + npm install -g markdownlint-cli 2>/dev/null || echo "npm install failed — lint will be skipped" + else + echo "npm not available on this runner — lint will be skipped" + fi - name: Lint markdown - run: markdownlint '*.md' --config /dev/null || true + run: | + command -v markdownlint >/dev/null 2>&1 || { echo "markdownlint unavailable — skipping"; exit 0; } + markdownlint '*.md' --config /dev/null || true diff --git a/lib/colors.sh b/lib/colors.sh index 9825046..5c511d3 100644 --- a/lib/colors.sh +++ b/lib/colors.sh @@ -8,6 +8,7 @@ NC='\033[0m' LOG_FILE="" VERBOSE=false +# shellcheck disable=SC2034 # used by lib modules DRY_RUN=false log() { diff --git a/lib/config.sh b/lib/config.sh index 2623435..6b2bf10 100644 --- a/lib/config.sh +++ b/lib/config.sh @@ -6,6 +6,7 @@ load_config() { while IFS='=' read -r key value || [ -n "$key" ]; do key="${key// /}" [ -z "$key" ] && continue + # shellcheck disable=SC2034 # globals used by lib modules case "$key" in WEBHOOK) DISCORD_WEBHOOK="$value" ;; LOG_LEVEL) [ "$value" = "verbose" ] && VERBOSE=true ;; diff --git a/lib/demo.sh b/lib/demo.sh index cf08a1c..cc6dbaa 100644 --- a/lib/demo.sh +++ b/lib/demo.sh @@ -22,7 +22,8 @@ run_demo() { echo "" step "2. Running suppress_enrollment..." - DRY_RUN=false + # shellcheck disable=SC2034 # used by lib modules +DRY_RUN=false suppress_enrollment "$demo_dir" 2>/dev/null || true sleep 1 diff --git a/runaway b/runaway index 7b06749..ae797c3 100755 --- a/runaway +++ b/runaway @@ -2,15 +2,18 @@ set -euo pipefail VERSION="2.0.0" +# shellcheck disable=SC2034 # used by lib modules STANDALONE_BUILD=false SCRIPT_DIR="$(cd "$(dirname "$0")" && pwd)" +# shellcheck disable=SC2034 # used by lib modules SCRIPT_PATH="$SCRIPT_DIR/$(basename "$0")" LIB_DIR="$SCRIPT_DIR/lib" for _lib in colors config detect validate dscl suppress backup status launchd heal firewall harden whitelist check monitor history doctor selfupdate uninstall report ma_detect demo vpn init suggest remediate telemetry predict discord; do _lib_path="$LIB_DIR/$_lib.sh" if [ -f "$_lib_path" ]; then + # shellcheck disable=SC1090 # libs live in $SCRIPT_DIR/lib source "$_lib_path" else echo "ERROR: Library not found: $_lib_path" >&2 @@ -411,6 +414,7 @@ cmd_monitor() { done set -- "${args[@]}" if [ -n "$webhook" ]; then + # shellcheck disable=SC2034 # used by lib/discord.sh DISCORD_WEBHOOK="$webhook" fi case "${1:-}" in @@ -571,6 +575,7 @@ cmd_interactive_normal() { parse_global_opts() { PARSED_ARGS=() while [ $# -gt 0 ]; do + # shellcheck disable=SC2034 # globals used by lib modules case "$1" in --verbose) VERBOSE=true; shift ;; --dry-run) DRY_RUN=true; shift ;; diff --git a/runaway-standalone.sh b/runaway-standalone.sh index 595b1db..2fbdbe3 100755 --- a/runaway-standalone.sh +++ b/runaway-standalone.sh @@ -14,6 +14,7 @@ NC='\033[0m' LOG_FILE="" VERBOSE=false +# shellcheck disable=SC2034 # used by lib modules DRY_RUN=false log() { @@ -134,6 +135,7 @@ load_config() { while IFS='=' read -r key value || [ -n "$key" ]; do key="${key// /}" [ -z "$key" ] && continue + # shellcheck disable=SC2034 # globals used by lib modules case "$key" in WEBHOOK) DISCORD_WEBHOOK="$value" ;; LOG_LEVEL) [ "$value" = "verbose" ] && VERBOSE=true ;; @@ -2659,7 +2661,8 @@ run_demo() { echo "" step "2. Running suppress_enrollment..." - DRY_RUN=false + # shellcheck disable=SC2034 # used by lib modules +DRY_RUN=false suppress_enrollment "$demo_dir" 2>/dev/null || true sleep 1 @@ -3232,6 +3235,7 @@ cmd_monitor() { done set -- "${args[@]}" if [ -n "$webhook" ]; then + # shellcheck disable=SC2034 # used by lib/discord.sh DISCORD_WEBHOOK="$webhook" fi case "${1:-}" in @@ -3392,6 +3396,7 @@ cmd_interactive_normal() { parse_global_opts() { PARSED_ARGS=() while [ $# -gt 0 ]; do + # shellcheck disable=SC2034 # globals used by lib modules case "$1" in --verbose) VERBOSE=true; shift ;; --dry-run) DRY_RUN=true; shift ;;