From 59487b693ed64707bc329ec1767f4d698e1b433e Mon Sep 17 00:00:00 2001 From: ruihan Date: Mon, 9 Nov 2026 10:55:53 +0800 Subject: [PATCH] ci: make ShellCheck install step failure-proof on heterogeneous runners --- .github/workflows/ci.yml | 17 +++++++---------- 1 file changed, 7 insertions(+), 10 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 0c3a5ee..26490b7 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -12,17 +12,14 @@ jobs: runs-on: ubuntu-latest steps: - uses: actions/checkout@v7 - - name: Install ShellCheck + - name: Install ShellCheck (best effort) run: | - if command -v shellcheck >/dev/null 2>&1; then - echo "shellcheck already available" - exit 0 - fi - if command -v apt-get >/dev/null 2>&1; then - sudo apt-get update -qq && sudo apt-get install -y -qq shellcheck - else - echo "no apt-get on this runner — ShellCheck will be skipped" - fi + command -v shellcheck >/dev/null 2>&1 && { echo "shellcheck already available"; exit 0; } + command -v apt-get >/dev/null 2>&1 || { echo "no apt-get on this runner — ShellCheck will be skipped"; exit 0; } + SUDO="" + command -v sudo >/dev/null 2>&1 && SUDO="sudo" + $SUDO apt-get update -qq && $SUDO apt-get install -y -qq shellcheck \ + || echo "shellcheck install failed — ShellCheck will be skipped" - name: Run ShellCheck run: | command -v shellcheck >/dev/null 2>&1 || { echo "shellcheck unavailable — skipping"; exit 0; }